Repository navigation
fix(broker): close invalid HTTPS responses at headers - #804
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upstream server could send an invalid response and leave its body open, keeping the model operation waiting until the exchange timeout. The broker now rejects invalid status/profile headers immediately and closes the request, response and isolated agent. Successful JSON/SSE responses retain the same final acceptance rules.
Added real loopback HTTPS regressions covering open error bodies, redirects, revoked requests, replay, endpoint/credential changes and successful responses. TLS checks and credential scope remain unchanged.
Validation: independent Astra review, including 1,936 old/new parser combinations with no acceptance differences; 84/84 tests across seven suites passed after integration; donor scoped lint/format/main typecheck passed. Required GitHub CI contexts must pass before merge. Tests use fixture CA certificates, synthetic authority and dummy credentials; this does not enable production launch or qualify full E5/A2.