Repository navigation
fix(smoke): include scoped file-read bridge method - #1041
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packaged Electron smoke expected 60 preload members and stopped before the settings/export checks. The existing scoped file-read control added in b22ec8a makes the bridge 61 members (50 invoke methods and 11 subscriptions).
Update the expected count and require
controlFileReadsto be present. The smoke never invokes that method; application behavior and permissions are unchanged.Validation: scoped Prettier and ESLint passed; independent source review confirmed the 61-member contract and existing method provenance. The original harness failed on the actual 0.20.0-beta package at this count; the corrected full smoke passed in 28 seconds against that unchanged package, including 12 workspaces, settings restart, six exports, configuration import and Electron isolation. The failed and passing receipts are retained separately. Required CI must pass on the final head before merge.