Repository navigation
feat(release): bind Windows candidate verification to signed assets - #1031
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind signed release membership and fresh Authenticode verification to one Windows installer. The CLI checks exact manifest bytes, selected asset name, expected tag/repository and signed size/digest against independent artifact/certificate-DER pins, fresh component receipt bytes and the final artifact hash. Receipts use new destinations; existing receipts supply no authority.
Validation: 108 focused tests (45 candidate, 63 unchanged Authenticode); two copied-source mutants fail identity/digest assertions (2/1). Scoped lint/format and independent source/security/test/evidence/final publication reviews passed. R2 changes help wording only, with direct help/format renewed. Five frozen sources are preserved through merge master.
Combined success is modeled. Reused native unsigned refusal applies only to the unchanged Authenticode component. No signed-positive qualification, target execution, signing, install, download, release or W10 acceptance. Existing verifier/trust/lock/workflows are unchanged. Acceptance requires exit 0 and matching complete fresh receipts; failed flush/close may leave pass-looking JSON. Normal Windows cache/network effects remain unmeasured.