Skip to content

quantizer: reject non-finite source tensors #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exochard wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

quantizer: reject non-finite source tensors #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions gguf-tools/deepseek4-quantize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,17 @@ static size_t checked_size_product(size_t a, size_t b, const char *what) {
return a * b;
}

static void validate_finite_f32(const char *name, const float *values, int64_t n) {
for (int64_t i = 0; i < n; i++) {
if (isfinite(values[i])) continue;
fprintf(stderr,
"error: non-finite value in source tensor %s at element %" PRId64 "\n",
name,
i);
exit(1);
}
}

static float *tensor_to_f32(const st_value *t, int64_t *n_out) {
const int64_t n = value_nelements(t);
float *out = xmalloc((size_t)n * sizeof(float));
Expand Down Expand Up @@ -1367,6 +1378,7 @@ static byte_buf generate_regular_hf(st_db *db, const char *gguf_name, const char
f32 = tensor_to_f32(&w, &n);
st_value_free(&w);
}
validate_finite_f32(hf_name, f32, n);
const float *imat = NULL;
if (target_uses_imatrix(target)) {
const char *names[2] = { gguf_name, hf_name };
Expand Down Expand Up @@ -1440,6 +1452,7 @@ static void generate_one_expert(expert_job *j, int xid) {
if (w.n_dims != 2 || w.shape[0] != j->nrows || w.shape[1] != j->ncols) die("expert shape mismatch");
f32 = tensor_to_f32(&w, &n);
}
validate_finite_f32(weight_name, f32, n);
const float *imat = NULL;
if (target_uses_imatrix(j->target)) {
const char *names[2] = { j->gguf_name, weight_name };
Expand Down