cuda: sanitize non-finite router scores - #740
Open
exochard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CUDA router computes probabilities and scores used by fixed-size top-k selection. A NaN or Inf in a router logit or bias can poison comparisons and leave an invalid expert selection, which later becomes an unsafe expert-tensor index.
Change
This keeps selection deterministic and prevents malformed numeric input from becoming an invalid routed-expert address. It does not change finite-input behavior.
Validation
Builds completed with no compiler warnings:
git diff --checkis clean. Target hardware is an RTX 4060 Ti 16 GiB (sm_89); the guard is independent of model quantization and applies to the CUDA DeepSeek router.