Skip to content

fix: make trigger_phrase match case-insensitive#1279

Merged
ashwin-ant merged 1 commit into
anthropics:mainfrom
JustinBis:jbis/case-insensitive-trigger-phrase
May 2, 2026
Merged

fix: make trigger_phrase match case-insensitive#1279
ashwin-ant merged 1 commit into
anthropics:mainfrom
JustinBis:jbis/case-insensitive-trigger-phrase

Conversation

@JustinBis
Copy link
Copy Markdown
Contributor

@JustinBis JustinBis commented May 1, 2026

Closes #910.

@Claude (capital C — from GitHub's @-mention autocomplete or iOS autocorrect) doesn't trigger the action because the regex in checkContainsTrigger has no i flag:

trigger_phrase: @claude
No trigger was met for @claude
Trigger result: false
No trigger found, skipping remaining steps

The workflow's outer if: contains(github.event.comment.body, '@claude') is case-insensitive, so the job runs but the action silently exits — looks to the user like Claude saw the mention and ignored it.

Fix: add "i" to the four RegExp constructions. Word-boundary behavior (email@claude.com → false) is unchanged. Added test cases for @Claude and @CLAUDE.

$ bun test
665 pass, 0 fail

GitHub @-mention autocomplete inserts @claude (capitalized) when users
pick the bot from the dropdown, but the trigger regex had no 'i' flag,
so the action would log 'No trigger was met for @claude' and exit. The
workflow's outer 'if: contains(...)' gate is case-insensitive, so the
job runs and looks like it silently ignored the user.

The regex was case-sensitive since the initial commit with no test
asserting either behavior; the existing tests focus on word-boundary
precision (email@claude.com etc.), not case.
@JustinBis JustinBis marked this pull request as ready for review May 1, 2026 23:54
@JustinBis
Copy link
Copy Markdown
Contributor Author

@ashwin-ant — small one closing #910. You'd flagged in Slack back in Jan that you didn't think this was case-sensitive; turns out it has been since the initial commit.

@ashwin-ant ashwin-ant merged commit 38f25dd into anthropics:main May 2, 2026
7 of 37 checks passed
mergify Bot added a commit to ArcadeData/arcadedb that referenced this pull request May 10, 2026
Bumps the github-actions group with 2 updates: [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) and [github/codeql-action](https://github.com/github/codeql-action).
Updates `anthropics/claude-code-action` from 1.0.111 to 1.0.119
Release notes

*Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).*

> v1.0.119
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.119>
>
> v1.0.118
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.118>
>
> v1.0.117
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.117>
>
> v1.0.116
> --------
>
> What's Changed
> --------------
>
> * Update HackerOne links in SECURITY.md by [`@​OctavianGuzu`](https://github.com/OctavianGuzu) in [anthropics/claude-code-action#1268](https://redirect.github.com/anthropics/claude-code-action/pull/1268)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.116>
>
> v1.0.115
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.115>
>
> v1.0.114
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.114>
>
> v1.0.113
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.113>
>
> v1.0.112
> --------
>
> What's Changed
> --------------
>
> * fix: make trigger\_phrase match case-insensitive by [`@​JustinBis`](https://github.com/JustinBis) in [anthropics/claude-code-action#1279](https://redirect.github.com/anthropics/claude-code-action/pull/1279)
>
> New Contributors
> ----------------
>
> * [`@​JustinBis`](https://github.com/JustinBis) made their first contribution in [anthropics/claude-code-action#1279](https://redirect.github.com/anthropics/claude-code-action/pull/1279)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.112>


Commits

* [`476e359`](anthropics/claude-code-action@476e359) chore: bump Claude Code to 2.1.138 and Agent SDK to 0.2.138
* [`ad67978`](anthropics/claude-code-action@ad67978) chore: bump Claude Code to 2.1.137 and Agent SDK to 0.2.137
* [`034cbdb`](anthropics/claude-code-action@034cbdb) chore: bump Claude Code to 2.1.136 and Agent SDK to 0.2.136
* [`939ae9c`](anthropics/claude-code-action@939ae9c) chore: bump Claude Code to 2.1.133 and Agent SDK to 0.2.133
* [`e9c374d`](anthropics/claude-code-action@e9c374d) Update HackerOne links in SECURITY.md ([#1268](https://redirect.github.com/anthropics/claude-code-action/issues/1268))
* [`9db782c`](anthropics/claude-code-action@9db782c) chore: bump Claude Code to 2.1.132 and Agent SDK to 0.2.132
* [`62238dd`](anthropics/claude-code-action@62238dd) chore: bump Claude Code to 2.1.131 and Agent SDK to 0.2.131
* [`7d7d305`](anthropics/claude-code-action@7d7d305) chore: bump Claude Code to 2.1.129 and Agent SDK to 0.2.129
* [`2cc1ac1`](anthropics/claude-code-action@2cc1ac1) chore: bump Claude Code to 2.1.128 and Agent SDK to 0.2.128
* [`38f25dd`](anthropics/claude-code-action@38f25dd) fix: make trigger\_phrase match case-insensitive ([#1279](https://redirect.github.com/anthropics/claude-code-action/issues/1279))
* See full diff in [compare view](anthropics/claude-code-action@fefa07e...476e359)
  
Updates `github/codeql-action` from 4.35.3 to 4.35.4
Release notes

*Sourced from [github/codeql-action's releases](https://github.com/github/codeql-action/releases).*

> v4.35.4
> -------
>
> * Update default CodeQL bundle version to [2.25.4](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.4). [#3881](https://redirect.github.com/github/codeql-action/pull/3881)


Changelog

*Sourced from [github/codeql-action's changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md).*

> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> [UNRELEASED]
> ------------
>
> No user facing changes.
>
> 4.35.4 - 07 May 2026
> --------------------
>
> * Update default CodeQL bundle version to [2.25.4](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.4). [#3881](https://redirect.github.com/github/codeql-action/pull/3881)
>
> 4.35.3 - 01 May 2026
> --------------------
>
> * *Upcoming breaking change*: Add a deprecation warning for customers using CodeQL version 2.19.3 and earlier. These versions of CodeQL were discontinued on 9 April 2026 alongside GitHub Enterprise Server 3.15, and will be unsupported by the next minor release of the CodeQL Action. [#3837](https://redirect.github.com/github/codeql-action/pull/3837)
> * Configurations for private registries that use Cloudsmith or GCP OIDC are now accepted. [#3850](https://redirect.github.com/github/codeql-action/pull/3850)
> * Best-effort connection tests for private registries now use `GET` requests instead of `HEAD` for better compatibility with various registry implementations. For NuGet feeds, the test is now always performed against the service index. [#3853](https://redirect.github.com/github/codeql-action/pull/3853)
> * Fixed a bug where two diagnostics produced within the same millisecond could overwrite each other on disk, causing one of them to be lost. [#3852](https://redirect.github.com/github/codeql-action/pull/3852)
> * Update default CodeQL bundle version to [2.25.3](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.3). [#3865](https://redirect.github.com/github/codeql-action/pull/3865)
>
> 4.35.2 - 15 Apr 2026
> --------------------
>
> * The undocumented TRAP cache cleanup feature that could be enabled using the `CODEQL_ACTION_CLEANUP_TRAP_CACHES` environment variable is deprecated and will be removed in May 2026. If you are affected by this, we recommend disabling TRAP caching by passing the `trap-caching: false` input to the `init` Action. [#3795](https://redirect.github.com/github/codeql-action/pull/3795)
> * The Git version 2.36.0 requirement for improved incremental analysis now only applies to repositories that contain submodules. [#3789](https://redirect.github.com/github/codeql-action/pull/3789)
> * Python analysis on GHES no longer extracts the standard library, relying instead on models of the standard library. This should result in significantly faster extraction and analysis times, while the effect on alerts should be minimal. [#3794](https://redirect.github.com/github/codeql-action/pull/3794)
> * Fixed a bug in the validation of OIDC configurations for private registries that was added in CodeQL Action 4.33.0 / 3.33.0. [#3807](https://redirect.github.com/github/codeql-action/pull/3807)
> * Update default CodeQL bundle version to [2.25.2](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.2). [#3823](https://redirect.github.com/github/codeql-action/pull/3823)
>
> 4.35.1 - 27 Mar 2026
> --------------------
>
> * Fix incorrect minimum required Git version for [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158): it should have been 2.36.0, not 2.11.0. [#3781](https://redirect.github.com/github/codeql-action/pull/3781)
>
> 4.35.0 - 27 Mar 2026
> --------------------
>
> * Reduced the minimum Git version required for [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158) from 2.38.0 to 2.11.0. [#3767](https://redirect.github.com/github/codeql-action/pull/3767)
> * Update default CodeQL bundle version to [2.25.1](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.1). [#3773](https://redirect.github.com/github/codeql-action/pull/3773)
>
> 4.34.1 - 20 Mar 2026
> --------------------
>
> * Downgrade default CodeQL bundle version to [2.24.3](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.24.3) due to issues with a small percentage of Actions and JavaScript analyses. [#3762](https://redirect.github.com/github/codeql-action/pull/3762)
>
> 4.34.0 - 20 Mar 2026
> --------------------
>
> * Added an experimental change which disables TRAP caching when [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158) is enabled, since improved incremental analysis supersedes TRAP caching. This will improve performance and reduce Actions cache usage. We expect to roll this change out to everyone in March. [#3569](https://redirect.github.com/github/codeql-action/pull/3569)
> * We are rolling out improved incremental analysis to C/C++ analyses that use build mode `none`. We expect this rollout to be complete by the end of April 2026. [#3584](https://redirect.github.com/github/codeql-action/pull/3584)
> * Update default CodeQL bundle version to [2.25.0](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.0). [#3585](https://redirect.github.com/github/codeql-action/pull/3585)
>
> 4.33.0 - 16 Mar 2026
> --------------------
>
> * Upcoming change: Starting April 2026, the CodeQL Action will skip collecting file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. Pull request analyses will log a warning about this upcoming change. [#3562](https://redirect.github.com/github/codeql-action/pull/3562)

... (truncated)


Commits

* [`68bde55`](github/codeql-action@68bde55) Merge pull request [#3885](https://redirect.github.com/github/codeql-action/issues/3885) from github/update-v4.35.4-803d9e8c3
* [`9739ad2`](github/codeql-action@9739ad2) Update changelog for v4.35.4
* [`803d9e8`](github/codeql-action@803d9e8) Merge pull request [#3883](https://redirect.github.com/github/codeql-action/issues/3883) from github/mbg/test/macro-wrapper
* [`0fd9c7d`](github/codeql-action@0fd9c7d) Merge pull request [#3882](https://redirect.github.com/github/codeql-action/issues/3882) from github/dependabot/github\_actions/dot-github/wor...
* [`922d6fb`](github/codeql-action@922d6fb) Use `makeMacro` instead of `test.macro`
* [`df77e87`](github/codeql-action@df77e87) Update test macro snippet
* [`6e3f985`](github/codeql-action@6e3f985) Add wrapper for `test.macro`
* [`e7a347d`](github/codeql-action@e7a347d) Merge pull request [#3881](https://redirect.github.com/github/codeql-action/issues/3881) from github/update-bundle/codeql-bundle-v2.25.4
* [`17eabb2`](github/codeql-action@17eabb2) Rebuild
* [`aaef09c`](github/codeql-action@aaef09c) Bump ruby/setup-ruby
* Additional commits viewable in [compare view](github/codeql-action@e46ed2c...68bde55)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
mergify Bot added a commit to ArcadeData/arcadedb-usecases that referenced this pull request May 10, 2026
…19 in the github-actions group [skip ci]

Bumps the github-actions group with 1 update: [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action).
Updates `anthropics/claude-code-action` from 1.0.111 to 1.0.119
Release notes

*Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).*

> v1.0.119
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.119>
>
> v1.0.118
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.118>
>
> v1.0.117
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.117>
>
> v1.0.116
> --------
>
> What's Changed
> --------------
>
> * Update HackerOne links in SECURITY.md by [`@​OctavianGuzu`](https://github.com/OctavianGuzu) in [anthropics/claude-code-action#1268](https://redirect.github.com/anthropics/claude-code-action/pull/1268)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.116>
>
> v1.0.115
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.115>
>
> v1.0.114
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.114>
>
> v1.0.113
> --------
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.113>
>
> v1.0.112
> --------
>
> What's Changed
> --------------
>
> * fix: make trigger\_phrase match case-insensitive by [`@​JustinBis`](https://github.com/JustinBis) in [anthropics/claude-code-action#1279](https://redirect.github.com/anthropics/claude-code-action/pull/1279)
>
> New Contributors
> ----------------
>
> * [`@​JustinBis`](https://github.com/JustinBis) made their first contribution in [anthropics/claude-code-action#1279](https://redirect.github.com/anthropics/claude-code-action/pull/1279)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.112>


Commits

* [`476e359`](anthropics/claude-code-action@476e359) chore: bump Claude Code to 2.1.138 and Agent SDK to 0.2.138
* [`ad67978`](anthropics/claude-code-action@ad67978) chore: bump Claude Code to 2.1.137 and Agent SDK to 0.2.137
* [`034cbdb`](anthropics/claude-code-action@034cbdb) chore: bump Claude Code to 2.1.136 and Agent SDK to 0.2.136
* [`939ae9c`](anthropics/claude-code-action@939ae9c) chore: bump Claude Code to 2.1.133 and Agent SDK to 0.2.133
* [`e9c374d`](anthropics/claude-code-action@e9c374d) Update HackerOne links in SECURITY.md ([#1268](https://redirect.github.com/anthropics/claude-code-action/issues/1268))
* [`9db782c`](anthropics/claude-code-action@9db782c) chore: bump Claude Code to 2.1.132 and Agent SDK to 0.2.132
* [`62238dd`](anthropics/claude-code-action@62238dd) chore: bump Claude Code to 2.1.131 and Agent SDK to 0.2.131
* [`7d7d305`](anthropics/claude-code-action@7d7d305) chore: bump Claude Code to 2.1.129 and Agent SDK to 0.2.129
* [`2cc1ac1`](anthropics/claude-code-action@2cc1ac1) chore: bump Claude Code to 2.1.128 and Agent SDK to 0.2.128
* [`38f25dd`](anthropics/claude-code-action@38f25dd) fix: make trigger\_phrase match case-insensitive ([#1279](https://redirect.github.com/anthropics/claude-code-action/issues/1279))
* See full diff in [compare view](anthropics/claude-code-action@fefa07e...476e359)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=anthropics/claude-code-action&package-manager=github\_actions&previous-version=1.0.111&new-version=1.0.119)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trigger_phrase matching is case-sensitive, should be case-insensitive

2 participants