Repository navigation
fix(streaming): return None from parsed_snapshot() for non-JSON text - #1973
Open
intertermux-code wants to merge 1 commit into
Open
intertermux-code wants to merge 1 commit into
intertermux-code wants to merge 1 commit into
Conversation
TextEvent.parsed_snapshot() (and ParsedBetaTextEvent.parsed_snapshot()) ran the accumulated snapshot through jiter.from_json with no guard, so ordinary prose - and the empty first delta - raised ValueError, and non-object JSON came back mistyped as Dict[str, Any]. Return None unless the snapshot parses as a JSON object; the JSON-object path, including mid-stream partials, is unchanged. Fixes anthropics#1961.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1961.
parsed_snapshot()ran the accumulated snapshot throughjiter.from_jsonunguarded, so ordinary prose — and the empty first delta of every text block — raisedValueError, and non-object JSON came back mistyped asDict[str, Any].It now returns
Noneunless the snapshot parses as a JSON object. The annotation is widened toOptional[Dict[str, Any]]and the method gets the docstring it was missing. The JSON-object path is unchanged, including mid-stream partials, soexamples/structured_outputs_streaming.pykeeps working.Added regression tests for both
TextEventandParsedBetaTextEvent.