fix(provider): enforce chunk timeout regardless of content type - #47621
Open
totalolage wants to merge 1 commit into
Open
fix(provider): enforce chunk timeout regardless of content type#47621totalolage wants to merge 1 commit into
totalolage wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #47605
Related to #26487.
Type of change
What does this PR do?
chunkTimeoutcurrently only checks responses markedtext/event-stream. If a provider omits or mislabels that header, a stalled response can leave the session waiting indefinitely.This removes the header check so the existing timeout also covers those responses and Bedrock binary streams. It applies to all response bodies through the SDK fetch wrapper, including JSON. Timeout defaults and opt-outs are unchanged. Native and WebSocket transports are outside this change.
Uses the same approach as the closed, unmerged #39516, with more regression coverage.
How did you verify your code works?
Added localhost SDK tests for missing and incorrect headers, reasoning followed by a stall, binary streams, JSON responses, cancellation, and retry-to-completion. The new timeout regressions fail against the original implementation.
bun typecheckpassed inpackages/opencode.The full run used a worktree-local
TMPDIRafter/tmpfilled, which affected unrelated tests. A clean-environment full-suite pass is still unverified. Focused tests and typecheck passed after the final test-only corrections.Checklist