refactor(core): use nonempty array guards - #45718
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three private paths manually prove non-emptiness by casting or reconstructing first-plus-rest tuples. Effect Array already supplies guards and mapping overloads that preserve the non-empty shape.
What Changes
Uses
isReadonlyArrayNonEmptyfor provider-hosted tool content,isArrayNonEmptyfor normalized local tool results and flattened child-process pipelines, and Effect Arraymapfor non-empty tool-content redaction. The already-normalized arrays are returned or published directly.Scope
Hosted empty content still falls back to text, local empty content still dies, cross-spawn still throws on an impossible empty flatten result, pipeline command/options ordering is unchanged, and every transferred content item uses the same sanitizer. PRs #45336 and #44806 touch other publisher state, while #45407 touches cross-spawn exit handling; none implement these collection refinements.
Verification
Core and Util typechecks passed, and all 84 focused tests passed. Oxlint completed with no errors and 36 pre-existing warnings. The push hook completed the 33-package workspace typecheck.