fix(app): show tree while opening files#36018
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Session “Open file” experience so the embedded file tree/sidebar is forced visible while the “Open file” placeholder UI is active, while still honoring the user’s persisted sidebar-open preference once a real file view is shown.
Changes:
- Force the file-browser sidebar open when
placeholderis active inSessionFileBrowserTab. - Extend the Playwright regression spec to assert sidebar visibility behavior across opening, switching away, selecting a file, and reopening when the persisted preference is “closed”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/pages/session/v2/session-file-browser-tab.tsx | Forces sidebar to be considered open while the Open File placeholder is active. |
| packages/app/e2e/regression/review-open-file.spec.ts | Adds regression coverage for sidebar visibility and restoration of closed-tree preference across tab switches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <> | ||
| <SessionReviewV2SidebarToggle opened={props.state.sidebarOpened()} onToggle={props.state.toggleSidebar} /> | ||
| <Show when={!props.state.sidebarOpened()}> | ||
| <SessionReviewV2SidebarToggle opened={sidebarOpened()} onToggle={props.state.toggleSidebar} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing