fix(provider): derive reasoning variants from models.dev#35985
fix(provider): derive reasoning variants from models.dev#35985rekram1-node wants to merge 1 commit into
Conversation
|
@rekram1-node I reproduced the current merge conflicts against
The conflicts appear to come from the Grok reasoning variant change (#36017) and the Meta Muse variant adjustments (#36079) merged after this branch diverged. I would be happy to resolve them while preserving those behaviors and their tests. Would you be open to a small follow-up PR targeting your |
|
Please release this fix soon. |
|
temporary workaround until the proper fix is released.
|
|
@rekram1-node hi Aiden, I ran into this while updating my setup for GPT-5.6 Sol and dug into why max wasn’t showing up for me in OpenCode. My agent concluded that although models.dev already includes it in reasoning_options, OpenCode currently drops that field and rebuilds the variants from a hardcoded list that stops at xhigh. So this PR looks like the right direction. A few notes from my tracing of the issue and discovering this PR:
|
|
I support this approach. Reasoning variants should be derived from provider/model metadata such as That should make new capabilities such as GPT-5.6 |
|
yeah ill release today yall, sorry for delay been busy w/ v2 |
|
how about using models.dev's model metadata? |
|
oh, already commented. |
|
I hope the maintainers can merge this PR as soon as possible, because testing on my local machine shows that "reasoningEffort": "max" does not take effect (this parameter is not sent) when capturing packets |
|
better PR: |
Summary
models.devreasoning_optionsinstead of model ID/version tablesVerification
bun typecheckcd packages/core && bun test test/plugin/models-dev.test.ts test/models.test.tscd packages/opencode && bun test test/provider/provider.test.ts test/provider/transform.test.ts test/provider/cf-ai-gateway-e2e.test.ts./packages/sdk/js/script/build.tsNote
xAI Responses sends promptCacheKey as prompt_cache_keyfailure; it reproduces independently of this change.