fix(tui): restore subagent navigation#35762
Open
aryaminus wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #34457
Also addresses the cancelled subagent navigation part of #32432 and the nested child navigation part of #15972.
Type of change
What does this PR do?
This restores navigation into subagent sessions after task cancellation or interruption.
The main regression was that failed task rows could have a valid child session id, but the TUI treated the failed state as an error-expansion click and returned before running the row click handler. This PR lets failed rows with an
onClicknavigate, while preserving error expansion for failed rows that do not navigate anywhere.It also keeps task cards linkable when the child session id is on top-level part metadata, keeps the subagent footer hint visible for completed/cancelled subagents, and fixes
session.child.firstto choose true direct children instead of siblings in nested sessions.This does not change Windows-specific
ctrl+x downkey handling from #33085 or remap Ctrl+X from #23322.How did you verify your code works?
npx --yes bun@1.3.14 test src/components/message-part.test.tsfrompackages/session-uinpx --yes bun@1.3.14 run test test/cli/run/footer.view.test.tsxfrompackages/opencodenpx --yes bun@1.3.14 run test test/cli/tui/inline-tool-wrap-snapshot.test.tsxfrompackages/tuinpx --yes bun@1.3.14 typecheckfrompackages/session-uinpx --yes bun@1.3.14 typecheckfrompackages/opencodenpx --yes bun@1.3.14 typecheckfrompackages/tuibun turbo typecheck(30 successful, 30 total)Screenshots / recordings
No screenshot; this is a navigation/click behavior fix.
Checklist