Skip to content

fix(app): avoid shortcut settings flash#35349

Merged
Brendonovich merged 4 commits into
devfrom
settings-flash-fix
Jul 6, 2026
Merged

fix(app): avoid shortcut settings flash#35349
Brendonovich merged 4 commits into
devfrom
settings-flash-fix

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep both settings dialogs controlled and wrap tab navigation in Solid's startTransition so the current tab remains painted while the next tab renders
  • eagerly import the visible Shortcuts controls (ButtonV2, IconButtonV2, TextInputV2, and SettingsListV2) while leaving the conditionally rendered icon lazy
  • merge current origin/dev while preserving upstream provider navigation

Validation

  • bun typecheck (packages/app)
  • bun x prettier --check for all three changed files
  • git diff --check origin/dev
  • Playwright at 1280x800 using the real app UI with mocked backend data
  • Playwright navigated General, Shortcuts, Servers, Providers, and Models with 188 animation-frame samples and no blank frames or errors
  • Synchronized before/after video

Comparison

  • before: b44bc0ad0740afe80beae0a1981c2c4d96f67173
  • after: 3bf3493b2240dbb5e1ba4928f68f7137200828d3

@opencode-agent opencode-agent Bot assigned Brendonovich and unassigned jayair Jul 4, 2026
@opencode-agent opencode-agent Bot marked this pull request as ready for review July 4, 2026 18:51
@Brendonovich Brendonovich enabled auto-merge (squash) July 6, 2026 07:50
@Brendonovich Brendonovich disabled auto-merge July 6, 2026 08:12
@Brendonovich Brendonovich merged commit 377d5d2 into dev Jul 6, 2026
10 checks passed
@Brendonovich Brendonovich deleted the settings-flash-fix branch July 6, 2026 08:12
arvsrn pushed a commit to arvsrn/opencode that referenced this pull request Jul 7, 2026
Co-authored-by: Jay <53023+jayair@users.noreply.github.com>
drewr pushed a commit to drewr/opencode that referenced this pull request Jul 7, 2026
Co-authored-by: Jay <53023+jayair@users.noreply.github.com>
shaheislam pushed a commit to shaheislam/opencode-vim that referenced this pull request Jul 7, 2026
Co-authored-by: Jay <53023+jayair@users.noreply.github.com>
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 9, 2026
Co-authored-by: Jay <53023+jayair@users.noreply.github.com>
anduimagui pushed a commit to anduimagui/opencode that referenced this pull request Jul 9, 2026
Co-authored-by: Jay <53023+jayair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants