revert(core): skip fff in node runtime#34549
Merged
Merged
Conversation
This reverts #34353 because tracing showed the desktop Node sidecar already resolves #fff to fff.node.ts and selects ripgrep through Fff.available() returning false. The explicit Node guard was defensive only and did not fix the observed command palette regression. Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(core): skip fff in node runtimeOPENCODE_DISABLE_FFF || !Fff.available()Rationale
Tracing showed the desktop Node sidecar already resolves
#ffftofff.node.ts, whereFff.available()returnsfalse, so desktop already selects ripgrep without the explicit Node runtime guard. The merged guard was defensive only and did not address the observed command palette regression.Testing
bun typecheckfrompackages/corebun test test/filesystem/search.test.ts test/location-filesystem.test.tsfrompackages/corebun turbo typecheck