Skip to content

fix(app): register export logs globally#34352

Merged
Hona merged 1 commit into
devfrom
export-logs-menu
Jun 30, 2026
Merged

fix(app): register export logs globally#34352
Hona merged 1 commit into
devfrom
export-logs-menu

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move logs.export into a dedicated desktop command registration mounted under the shared app CommandProvider
  • keep desktop menu entries as normal command-backed items instead of duplicating Export Logs handling in each layout
  • add a regression test that Export Logs remains wired through the desktop command registry

Tests

  • bun test --preload ./happydom.ts ./src/desktop-menu.test.ts (from packages/app)
  • bun typecheck (from packages/app)
  • git push pre-push hook: bun turbo typecheck

@opencode-agent opencode-agent Bot changed the title fix(desktop): keep export logs menu enabled fix(app): register export logs globally Jun 28, 2026
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
@Hona Hona marked this pull request as ready for review June 30, 2026 03:03
@Hona Hona requested review from Brendonovich and Hona as code owners June 30, 2026 03:03
Copilot AI review requested due to automatic review settings June 30, 2026 03:03
@Hona Hona added the beta label Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Hona Hona merged commit e687eb9 into dev Jun 30, 2026
10 checks passed
@Hona Hona deleted the export-logs-menu branch June 30, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants