fix(codex): exclude -pro models from ChatGPT-account model list#32276
Closed
devinoldenburg wants to merge 2 commits into
Closed
fix(codex): exclude -pro models from ChatGPT-account model list#32276devinoldenburg wants to merge 2 commits into
-pro models from ChatGPT-account model list#32276devinoldenburg wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a centralized model-support check for ChatGPT (OAuth) accounts when using the Codex backend, and validates the behavior with new unit tests.
Changes:
- Introduced
isModelSupportedForChatGPTAccountto consolidate model filtering logic. - Excluded
*-promodels for OAuth/ChatGPT accounts to avoid backend rejections. - Added unit tests covering allow-list behavior, version heuristic, and
-proexclusions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/opencode/src/plugin/openai/codex.ts | Adds the helper function and uses it to filter provider models for OAuth sessions. |
| packages/opencode/test/plugin/codex.test.ts | Adds tests validating the new model support filtering rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
devinoldenburg
force-pushed
the
fix/codex-exclude-pro-models-chatgpt-account
branch
2 times, most recently
from
June 14, 2026 06:52
faec96c to
86a1139
Compare
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
The OAuth model filter auto-allows any `gpt-<version>` model newer than 5.4 via a version heuristic. That heuristic lets `gpt-5.5-pro` (and other `-pro` variants) appear as available for ChatGPT-account (OAuth) sessions, but the Codex backend does not serve `-pro` models to ChatGPT accounts — they are API-key only. Selecting one fails at request time with: Bad Request: The 'gpt-5.5-pro' model is not supported when using Codex with a ChatGPT account. Extract the filter predicate into `isModelSupportedForChatGPTAccount` and exclude `*-pro` ids from the heuristic path so these models no longer show up as options for OAuth accounts. Explicitly allow-listed ids still take precedence, so a future `-pro` model can be re-enabled by adding it there if OpenAI starts serving it. Fixes #26115
Address review feedback: `parseFloat` mis-orders multi-digit minor versions (e.g. "5.10" parses as 5.1), so `gpt-5.10` would be wrongly excluded by the `> 5.4` heuristic. Capture major and minor separately and compare as integers. Added a regression test for the multi-digit minor case.
devinoldenburg
force-pushed
the
fix/codex-exclude-pro-models-chatgpt-account
branch
from
June 15, 2026 11:53
1caf779 to
2ddd4ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.