fix(mcp): mcp auth returns disabled instead of connected after OAuth#20279
Closed
Ayushlm10 wants to merge 2 commits into
Closed
fix(mcp): mcp auth returns disabled instead of connected after OAuth#20279Ayushlm10 wants to merge 2 commits into
mcp auth returns disabled instead of connected after OAuth#20279Ayushlm10 wants to merge 2 commits into
Conversation
After successful OAuth, finishAuth called createAndStore with the raw
config which may have enabled=false (e.g. server was previously
disconnected). This caused create() to short-circuit and return
status disabled instead of reconnecting.
Pass { ...mcpConfig, enabled: true } to match what connect() already
does.
Fixes anomalyco#20278
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20278
Type of change
What does this PR do?
After completing OAuth for a remote MCP server,
opencode mcp auth <name>shows "Unexpected status: disabled" even though auth succeeded.The problem is in
finishAuth— it callscreateAndStore(mcpName, mcpConfig)with the raw config fromgetMcpConfig(). Ifenabledisfalse(e.g. server was previously disconnected),create()short-circuits and returns{ status: "disabled" }without reconnecting.The fix passes
{ ...mcpConfig, enabled: true }tocreateAndStore, which is the same patternconnect()already uses on line 601.How did you verify your code works?
bun run dev -- mcp auth <server-name>before the fix — got "Unexpected status: disabled"Screenshots / recordings
N/A — CLI output change only.
Checklist