Enable SourceLink and add back generated code#548
Merged
tmilnthorp merged 8 commits intov4from Nov 6, 2018
Merged
Conversation
This reverts commit f914132.
angularsen
force-pushed
the
v4-sourcelink-and-add-back-generated-code
branch
2 times, most recently
from
ca8fda0 to
de0e211
Compare
angularsen
changed the title
Instead of zip clone, since SourceLink nuget fails to resolve the git repository without a proper clone.
This should tell GitHub and possibly other tools to collapse these by default when reviewing PRs. You can still expand them if you want to look at them, but it greatly reduces noise when generating hundreds of files. Source: https://robots.thoughtbot.com/github-diff-supression
Remove symbols package.
angularsen
force-pushed
the
v4-sourcelink-and-add-back-generated-code
branch
from
de0e211 to
40083cf
Compare
tmilnthorp
approved these changes
Nov 6, 2018
| # C# | ||
| *.cs diff=csharp | ||
| *.cs diff=csharp | ||
| *.g.cs linguist-generated |
Collaborator
There was a problem hiding this comment.
Might have to make this
**/*.g.cs linguist-generated=true
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry of #538, this time for v4 branch.
.g.csfiles as generated to auto-collapse in GitHub PR reviewsSourceLink debugging 🕵️
Tested with VS 2017.8.9 and a simple test project, then trying to step into the library with a nuget built by AppVeyor. When using locally built nugets, it will find the original source code unless you moved it first.
Auto-collapse .g.cs files 🔼
A single-line change to 180 generated files are now collapsed by default. Previously it would load as many diffs as it could muster (limited to a couple of full screens or so).
No more .symbols.nupkg files
I also did it for WindowsRuntimeComponent, but it seems UWP apps don't support navigating into nuget source code - even with v3's symbols nugets or with v4's SourceLink. Did it for consistency.