fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions#7832
fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions#7832filipesilva merged 1 commit intoangular:masterfrom AmitMY:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
filipesilva
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this 👍
filipesilva
left a comment
There was a problem hiding this comment.
Travis is failing on the commit message, can you change it to fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions please?
|
Done. All checks have passed, no idea why travis failed before |
|
We have a check for the commit message which makes one of the jobs fail. Your new commit message solved that 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #7197, in continuation to #7563
Thanks @mtraynham for the original fix.
This resolves an issue with browsers throwing net::ERR_CONTENT_LENGTH_MISMATCH for large files or slow connections, when using Webpack Dev Server. Large files, such as a vendor javascript bundle, are susceptible to this bug which is tracked all the way back to the NodeJS http module. A change in NodeJS 8.0 broke the keepAliveTimeout handling where active requests don't reset the timeout timer. This is a proposal fix in NodeJS 8.6, but that is what was last time as well.
The keepAliveTimeout defaults to 5 seconds, which may be too short. This change increases that keepAliveTimeout to 30 seconds, but only if the Node process has versions starting with 8