[Bug]: ndk r16 cleanup possible in libc++

[enh-google]

Description

i was going to remove the extern "C" in the one of these files i stumbled across. (because the answer to the FIXME's question is, no, this isn't needed --- it's only there because in danalbert's original commit it also covered function definitions, but the scope was gradually reduced until it only covered the #include.)

but then i noticed (a) the whole file can probably go, because this is only for NDK r16 and earlier, and (b) there are two copies of this.

so both these files should probably be deleted, and their "call" sites removed?

https://source.corp.google.com/search?q=__NDK_MAJOR__%20file:third_party%2Fllvm%2Fllvm-project

Upstream bug

No response

Commit to cherry-pick

No response

I am using a supported NDK

• I have checked and the NDK I'm using is currently supported

Affected versions

r28

Host OS

Linux

Host OS version

N/A

Affected ABIs

arm64-v8a

[enh-google]

("danalbert's original commit" is llvm/llvm-project@b38f8f0.)

[DanAlbert]

Wow, that's an old commit.

Yeah, typically the hold out for removing stuff like that from upstream (I obviously don't care) is Chrome, and I know they updated to bionic's HEAD a year or so ago. Firefox is the other org that commonly has problems when people remove support for ancient NDKs.

Closing since there's nothing for the NDK to do here. Anyone that wants to take the time to get that merged upstream and deal with any potential fallout from CI builds using ancient NDK sysroots but ToT LLVM can have at it, but I've been burned by that a few too many times.

[enh-google]

llvm/llvm-project#148879