Repository navigation
Make E2E env setup more robust; add GHA reporter for E2E and JS unit tests - #6280
Conversation
16e4e06 to
46d1826
Compare
|
|
||
| mysql: | ||
| image: mysql:5.7 | ||
| image: mariadb:10 |
There was a problem hiding this comment.
The mysql Docker image doesn't have an arm64 compatible build yet, but mariadb does so I went with that.
| "@wordpress/jest-puppeteer-axe": "3.0.3", | ||
| "@wordpress/plugins": "3.0.0", | ||
| "@wordpress/scripts": "15.0.1", | ||
| "@wordpress/scripts": "16.0.0", |
There was a problem hiding this comment.
Updated @wordpress/scripts to v16 as it uses puppeteer-core v9, which has support for Apple M1.
|
Plugin builds for 2e14cbc are ready 🛎️!
|
|
The "Unit test: PHP 8.0, WP trunk" PR check is currently failing with:
I see that WordPress/gutenberg#32008 was merged recently to resolve the issue, and should be apart of Gutenberg v10.7 set to be released today (according to the milestone due date). |
Bug fix was shipped as apart of the 10.6.2 release: https://github.com/WordPress/gutenberg/releases/tag/v10.6.2. |
delawski
left a comment
There was a problem hiding this comment.
The changes look well to me. I've tried out the E2E tests locally and they work as expected.
|
@pierlon Is the Percy failure due to there not being a previous snapshot to compare against? |
|
@westonruter It seems to be due to the work being done in #6282 since that PR is using this branch as the base. It can be ignored for now. |
# Conflicts: # package-lock.json
|
Cool. The conflicts in |
|
The "Build, test & measure / Unit test: PHP 8.0, WP trunk" PR check is failing once again, but with a different error:
We can ignore that error for now as it has been resolved via WordPress/gutenberg#32059 and should be available in the upcoming Gutenberg 10.7 release. |
|
So we should wait for Gutenberg 10.7 to be released? |
|
Nope, shouldn't be considered a blocker since this issue only occurs on WP trunk. |
|
But we currently have |
|
I don't think that should be the case since it's expected that tests will fail from time to time, especially in this case where the failure is due to external factors not related to the plugin. |
|
OK, I removed trunk from the checks required to pass. |
|
Moving this to 2.2 as I don't think we need this on the 2.1 branch. |
Summary
Checklist