Skip to content

Global / per Story Slide Duration Options #1995

Closed

Description

@miina

AC: User can set the slide duration options either globally or per story.
AC: The global / per story setting can be overridden per slide.

Investigate options for setting the slide duration per story or globally. This way the user wouldn't have to set each slide separately in the likely use case of wanting to use auto or media for all slides.

Activity

  1. added this to the v1.2 milestone on May 21, 2019
  2. removed this from the v1.2 milestone on Jun 10, 2019
  3. swissspidy commented on Jul 3, 2019

    @swissspidy
    Collaborator

    Note that it's finally possible to actually extend the document sidebar with the upcoming new Gutenberg version.

    See WordPress/gutenberg#13361 / WordPress/gutenberg#13357

  4. self-assigned this
    on Aug 26, 2019
  5. swissspidy commented on Sep 9, 2019

    @swissspidy
    Collaborator

    @dero The PR is still set to draft – it's not clear to me whether this is now ready for review or still WIP. Can you clarify?

  6. added this to the v1.3 milestone on Sep 10, 2019
  7. dero commented on Sep 11, 2019

    @dero
    Contributor

    Summary for QA:

    This PR introduces a concept of global settings and story settings.

    • Global settings: set on AMP plugin settings page, applied as defaults to every new story.
    • Story settings: set on a story post, applied as defaults to every new page.
    • Page settings: set on a page block, applied to that block only.

    Test instructions:

    1. Go to AMP plugin settings page and enable the Stories experience.
    2. Change the values in the Stories Settings field and check the values persist upon saving.
    3. Create a new story and notice a "Story Settings" panel in the "Document" tab.
    4. Verify that values in that panel match what was set globally in step 2.
    5. Click the first page and on the "Block" tab verify that the values in the "Page Settings" box match the "Story Settings".
    6. Change the "Story Settings" to something else in the "Document" tab.
    7. Verify that the "Page Settings" in the "Block" tab did not change.
    8. Create a new page.
    9. Verify that the "Page Settings" in the "Block" tab are equal to what was set in step 6.
    10. Create a new page.
    11. Change the "Page Settings" in the "Block" tab for that page to something else.
    12. Check that other pages were not affected and their "Page Settings" stayed intact.
    13. Check that the "Story Settings" in the "Document" tab remained unchanged.
    14. Finish the story and publish it.
    15. Verify that the advancement options are applied correctly on the front-end.

    Screencast: https://www.youtube.com/watch?v=TppJ96XE-qU

  8. changed the title [-][AMP Stories] Global / per Story Slide Duration Options[/-] [+]Global / per Story Slide Duration Options[/+] on Sep 11, 2019
  9. csossi commented on Sep 13, 2019

    @csossi

    Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions