Skip to content

chore: use lockfiles for NPM dependencies#350

Merged
daniel-graham-amplitude merged 7 commits intomainfrom
AMP-145287-use-lockfiles
Dec 30, 2025
Merged

chore: use lockfiles for NPM dependencies#350
daniel-graham-amplitude merged 7 commits intomainfrom
AMP-145287-use-lockfiles

Conversation

@daniel-graham-amplitude
Copy link
Copy Markdown
Contributor

@daniel-graham-amplitude daniel-graham-amplitude commented Dec 30, 2025

Summary

Instead of installing dependencies dynamically via "npx", pin down the dependencies using lockfile + npm ci so that we don't get any unexpected dependencies when running semantic-release.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Note

CI release workflow tweaks

  • Update release.yml to install Node dependencies with npm ci and run semantic-release via npm exec (both dry-run and real), keeping npm config set ignore-scripts true.
  • Add node_modules/ to .gitignore.

Written by Cursor Bugbot for commit d1bbae3. This will update automatically on new commits. Configure here.

@daniel-graham-amplitude daniel-graham-amplitude changed the title chore: migrate to lockfiles chore: use lockfiles for NPM dependencies Dec 30, 2025
@macroscopeapp
Copy link
Copy Markdown

macroscopeapp bot commented Dec 30, 2025

Replace ad-hoc npx -p installs with npm ci and run semantic-release via npm exec in release.yml to meet AMP-145287

The Release workflow installs Node dependencies with npm ci and runs semantic-release using npm exec, adds node_modules/ to .gitignore, and introduces package.json and package-lock.json for pinned dependencies.

🖇️ Linked Issues

Addresses AMP-145287 by removing npx -p usage in the Release workflow, contributing to the AMP-145285 epic under the AMP-91393 initiative.

📍Where to Start

Start with the Release job steps in release.yml, focusing on the npm ci and npm exec semantic-release changes.


Macroscope summarized d1bbae3.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@daniel-graham-amplitude daniel-graham-amplitude marked this pull request as draft December 30, 2025 18:11
@daniel-graham-amplitude daniel-graham-amplitude marked this pull request as ready for review December 30, 2025 21:53
Copy link
Copy Markdown
Collaborator

@sojingle sojingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@daniel-graham-amplitude daniel-graham-amplitude merged commit 3319efb into main Dec 30, 2025
24 of 28 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the AMP-145287-use-lockfiles branch December 30, 2025 23:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

🎉 This PR is included in version 1.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants