Conversation
|
I guess we should create a new 4.x branch for this and release it as 4.0? |
|
@kelunik I think at least a beta release would be good so that we can start seeing if this is suitable across more comprehensive test suites. |
|
I implemented these changes in a branch I could install through Composer and tested this works on a test suite making extensive use of the Loop. I believe that this is the correct approach for PHPUnit 10 support. @kelunik When possible could this be merged in and a release created? @danog Nice work on this! I thought it would be more complicated but I like how simple your solution is. 👍 |
| "php": ">=8.1", | ||
| "amphp/amp": "^3", | ||
| "phpunit/phpunit": "^9", | ||
| "phpunit/phpunit": "^10", |
There was a problem hiding this comment.
I don't see any breaking change. Support for PHPUnit 10 can be added without removing support for the version 9.
| "phpunit/phpunit": "^10", | |
| "phpunit/phpunit": "^9|^10", |
No description provided.