Skip to content

Enable HTML anchor in Details block - #256

Merged
jaymcp merged 1 commit into
mainfrom
feat/details-anchor
Aug 2, 2024
Merged

Enable HTML anchor in Details block#256
jaymcp merged 1 commit into
mainfrom
feat/details-anchor

Conversation

@jaymcp

@jaymcp jaymcp commented Jun 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: #333

Steps to test:

  1. add a Details block
  2. in settings, add a HTML anchor
  3. visit the frontend
  4. set the URI to include the anchor as the fragment
  5. the page should jump down to your details block

@jaymcp
jaymcp requested a review from Gentyspun June 27, 2024 14:40
Base automatically changed from release/v1.1.0 to main July 3, 2024 11:09
Gentyspun
Gentyspun approved these changes Aug 2, 2024
View reviewed changes

@Gentyspun Gentyspun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaymcp
jaymcp merged commit 047be81 into main Aug 2, 2024
jaymcp added a commit that referenced this pull request Aug 15, 2024
@jaymcp
Add support for HTML anchors in Details block (#256)
d68fb74
@jaymcp
jaymcp deleted the feat/details-anchor branch September 12, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Gentyspun Gentyspun Gentyspun approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaymcp @Gentyspun