Repository navigation
Sync SDK with Etsy API spec - taxonomy property filters - #45
Merged
Merged
Conversation
Add the optional supports_variations and supports_attributes query parameters to SellerTaxonomyResource.get_properties_by_taxonomy_id, matching the getPropertiesByTaxonomyId spec change. Update the spec baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
amitray007
added
the
api-drift
amitray007
changed the title
Contributor
Test Coverage ReportOverall: 100% (1739/1739 statements covered) Coverage by file
Updated by PR Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR syncs the SDK with the current Etsy OAS spec. Coverage stays at 100% (105/105 operations). Etsy has published no new GitHub releases since 2026-03-24, so the spec diff is the only source of changes.
Found 0 Must Fix, 1 Should Fix, 1 Informational.
Should Fix
getPropertiesByTaxonomyId:supports_variationsandsupports_attributes.SellerTaxonomyResource.get_properties_by_taxonomy_idnow accepts both. Both default toNone, which sends no parameter, so existing calls send the same request as before.Informational (no code impact)
TransactionVariationshas a new response field,mime_type. It is a nullable enum of image and PDF MIME types for personalization uploads. The SDK has no response models, so it needs no change.specs/audit-ignore.jsonagainst the code and the spec, and they still hold. There are no stale ignores and no new enum values.Test plan
pytest: 441 passed. Adds a test for the filtered call and updates the default-call test to check the query parameters.python scripts/audit_sdk.py --spec specs/latest.json: no query/path parameter drift, no request body drift, no stale ignores, 0 code issues.python scripts/check_version_consistency.py: OK at 1.2.1.make_requestsends query parameters throughgenerate_get_uri, which writes booleans astrueorfalseand leaves outNone.specs/baseline.jsonis updated to the audited spec.🤖 Generated with Claude Code