Skip to content

fix(ui): open a new side chat directly from workspace button - #871

Merged
sox8502 merged 4 commits into
mainfrom
daniel/side-chat-button
Nov 4, 2026
Merged

sox8502 merged 4 commits into
mainfrom
daniel/side-chat-button

Conversation

@sox8502

@sox8502 sox8502 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Clicking the workspace Side chat button now opens and focuses a new side-chat draft immediately, including when its dropdown is already open. Desktop saved chats remain available on hover or Arrow Down, without a chevron. A separate mobile list button preserves touch access.

Uses the existing creation callback across expanded, compact, and mobile layouts; removes the obsolete hover-origin flag.

Validation:

  • Reproduced the original extra-click behavior in the Codex in-app browser.
  • One-click creation in expanded and compact layouts, and one-tap creation at mobile width; composer receives focus.
  • Sent a message in the new side chat and received SIDE_CHAT_OK.
  • Reopened saved chats, tested Arrow Down, and created a draft while the picker was open.
  • User verified the desktop chevron removal.
  • UI production build, typecheck, localization/style checks, and all UI tests before test-only cleanup; the three remaining side-chat tests pass afterward.
  • Rust formatting, clippy, and locked build.
  • Full locked Rust test suite (1,352 passed; three ignored).
  • Prior implementation review: Greptile 5/5. Follow-up review waived by user.
  • GitHub CI before the final user-verified chevron removal.
  • Physical touch-device check (mobile browser layout verified).

@sox8502

sox8502 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the separate picker button restores touch access to saved chats.

Summary

The workspace Side chat button opens a draft directly. Saved chats remain available through a separate picker button.

  • Workspace Side chat clicks now start a draft right away.

Reviews (2) · Last reviewed commit: "fix(ui): retain touch access to saved si..." · Reviewed by Greptile

Comment thread ui/src/components/WorkspaceTools.tsx Resolved
@sox8502

sox8502 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502
sox8502 merged commit bb1ec22 into main Nov 4, 2026
10 checks passed
@sox8502
sox8502 deleted the daniel/side-chat-button branch November 4, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant