Repository navigation
Treat a non-numeric SSH exit_code receipt as missing so dead runs finalize - #792
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…alize Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
[Medium impact] This PR appears safe to merge. SummarySSH inspection now treats an invalid
Reviews (1) · Last reviewed commit: "Treat a non-numeric SSH exit_code receip..." · Reviewed by Greptile |
5 tasks done
Contributor
|
superseded by #862. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OR-618.
Summary
printf ... > exit_codestill createsexit_codebut cannot write to it, so the file is empty.host_job_script(and the containerhost_state) checked[ -f exit_code ]and printedEXIT.parse_job_staterejected that, andwatch_ssh_jobread the rejection as an outage ("Monitoring unavailable: unexpected inspect output: EXIT"). So the run stayedrunning/Cancelling forever, and repeatingorx exp canceldid nothing.grep -Eqx '[0-9]+'). Anything else goes on to the existing pid liveness check. A dead launcher then reportsDEAD: the run is markedcancelledif a cancel was requested, otherwiseerrorwith "process died without an exit code". The invalid receipt stays on disk untouched as evidence.host_inspect_reports_a_vanished_run_dir_as_missingto cover an empty receipt with a dead pid.Test plan
cargo fmt --check,cargo clippy --locked -- -D warnings,cargo test --locked jobs::ssh; CI greenmain: SSH backend to localhost,--remote-rootset to a 64 MB tmpfs. The run fills the disk and exits, leaving a 0-byteexit_codeand no processes.orx exp cancelwas accepted twice, but the run stayedrunning/Cancelling.CLAUDE_OK) in the same slot:exit_codeleft in place, no processes, and the run finalizes on its own asfailed("process died without an exit code (killed?)").dd ... || true; sleep 600) and then stopped withorx exp cancel: 0-byteexit_code, supervisorfinished (cancelled), and the dashboard showsCancelled.--image) SSH path. Only the shared script change applies there.Automation improvements
CODEX_AUTH_JSONholds a refresh token that has already been used. Refreshing that secret from a fresh ChatGPT Codex login would let Codex-dependent bugs be reproduced.Link to Devin session: https://app.devin.ai/sessions/bf679bd9a4624330abbceb026ca2296d
Open in Devin Desktop: https://app.devin.ai/desktop/session/bf679bd9a4624330abbceb026ca2296d?variant=devin