Repository navigation
Reopen the pinned SSH master in the background so finished runs reconcile (OR-598) - #778
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…le (OR-598) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. SummaryThe PR reopens an unmanaged host's saved SSH connection before starting the remote helper.
Reviews (2) · Last reviewed commit: "Reopen the pinned SSH master after valid..." · Reviewed by Greptile |
Contributor
Author
|
@greptileai review |
5 tasks done
Contributor
|
superseded by #862. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OR-598.
Summary
-S <socket>,ProxyCommand=false,BatchMode=yes). If that master dies (network drop, sleep, ControlPersist expiry), nothing reopens it until a manualorx compute connect. Meanwhilewatch_ssh_jobkeeps the run atrunningeven after the host is back and the remoteexit_codeexists.src/jobs/ssh/service/transport.rs): afterstate::validate_configuration,transport::connectrunsreopen_masterfor unmanaged targets:ssh -oBatchMode=yes -oClearAllForwardings=yes -T <resolved.options> -- <dest> true. It uses only the pinned options and snapshot config, so the master comes back at the same ControlPath. It never prompts and is capped at 30s. Hosts that need a password or MFA still fail and show the existing "Use Connect" message. A live master just multiplexestrue.reopen_never_prompts_and_uses_the_pinned_routecovers the arguments.Test plan
cargo build --locked,cargo fmt --check,cargo clippy --locked -- -D warnings,node ui/scripts/check-i18n.mjs,node ui/scripts/check-styles.mjs,pnpm typecheckcargo test --locked: 1270 passed. 3local::projectstests fail locally only because of this VM's global git identity; they are unrelated to this diff. CI is authoritative.main(Linux, Docker sshd hostlab, key auth). Steps:orx exp run --backend ssh --host lab --no-container, disconnect the container network, let the remote job writeexit_code0, then reconnect. The run stayed Running for more than 4 minutes ("Monitoring unavailable … Reconnect with orx compute connect") and only finished after a manual Connect.Link to Devin session: https://app.devin.ai/sessions/8fd5cca120e446cd8817fe62783a6b58
Open in Devin Desktop: https://app.devin.ai/desktop/session/8fd5cca120e446cd8817fe62783a6b58?variant=devin