Repository navigation
Mirror local run logs that contain non-UTF-8 bytes (OR-581) - #746
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryReads local run logs as bytes and replaces invalid UTF-8 instead of skipping the whole file.
Reviews (1) · Last reviewed commit: "Mirror local run logs that contain non-U..." · Reviewed by Greptile |
Contributor
|
superseded by #862. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OR-581.
Summary
cmd.exewrite output in the console code page, not UTF-8.localbox::stream_logsreadlocal-runs/<id>/logwithread_to_stringand treated the decode error like a missing file, returningOk(skip)on every poll. As a result, the supervisor (tail_logs_local) never mirrored a line, andrun-logs/<id>.logstayed at 0 bytes even after the run finished.String::from_utf8_lossy. Invalid bytes becomeU+FFFD, and the line count stays the same, so theskip/seenbookkeeping still works. A missing file still returnsOk(skip).stream_logshas only one caller,tail_logs_local, and it needed no change.stream_logs_keeps_lines_that_are_not_utf8test.25°Cbecomes25\uFFFDC). Output is no longer dropped, but the characters are not decoded through the console code page.Test plan
windows build, test. Scope review (fresh context): yes. Greptile: 5/5, no notes.main: Claude Code rantrain.shfrom the dashboard as a local run. The script prints 2,000 lines, then acmd.exeline containing°. The run finisheddone/exit 0. The run-dirlogis 44,949 bytes, butorx logsreports a 0-byterun-logsfile.done/exit 0, andorx logsreports a 44,950-byterun-logsfile whose preview ends with the summary line andDONE exit 0.Bug reproduction on main (Windows)
Post-fix check on this branch (Windows)
Automation improvements
scripts/dev-slot.mjsexits with "requires macOS or Linux" on Windows, so the Windows sessions start an isolatedorx upby hand. Adding Windows support, or documenting theORX_DATA_DIR/ORX_CACHE_DIR/XDG_CONFIG_HOMEsetup, would save setup time in every Windows run.CODEX_AUTH_JSONis stale (codex execfails withrefresh_token_reused). Refreshing it from a new ChatGPT Codex login would make Codex usable for issues that need it.Link to Devin session: https://app.devin.ai/sessions/53f7e0b94ad343b4b9abfb76f9372abe
Open in Devin Desktop: https://app.devin.ai/desktop/session/53f7e0b94ad343b4b9abfb76f9372abe?variant=devin