Repository navigation
feat(ui): show experiment run duration - #477
Draft
Tiancheng-Xu wants to merge 2 commits into
Draft
Tiancheng-Xu wants to merge 2 commits into
Tiancheng-Xu wants to merge 2 commits into
Conversation
Author
|
Merged current main and regenerated the embedded UI bundle in Fresh verification: 210 UI tests, 9 dev-slot tests, 6 release-note tests, UI style lint, i18n/typecheck/build, both Rust formatting checks, and an unchanged repeated Vite bundle build. The test plan now records these results and explicitly leaves Rust clippy/build/tests and platform CI pending. Keeping this draft until those checks can be verified. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #473
The experiments table showed when the latest run started but not how long it took. This adds elapsed duration beside the existing relative timestamp. Finished runs use
endedAt; active runs update every second.Current main has been merged into this branch, and the embedded UI bundle has been regenerated to resolve the generated-asset conflicts.
Test plan
corepack pnpm@10.16.1 buildinui(i18n lint, typecheck, Vite build)node --test --experimental-strip-types --test-reporter=spec ui/tests/*.test.mjs(210 passed)node ui/scripts/check-styles.mjsnode --test scripts/dev-slot.test.mjs(9 passed)python3 scripts/test_release_notes.py(6 passed)cargo fmt --all --checkandcargo fmt --manifest-path windows/launcher/Cargo.toml --check(Rust 1.95.0)git diff --check