Conversation
Owner
allisson
commented
May 15, 2026
- TxDb branded type (db/tx.ts) + asTx() — every write-path service signature and the quota advisory-lock helpers now require TxDb, making accidental calls on app.db a compile error. Closes a latent gap where pg_advisory_xact_lock would silently no-op without a surrounding transaction.
- app.clock decorator (plugins/clock.ts) owns every time-sensitive read: session expiry, TOTP windows, recovery token expiry, auth idle check, cleanup interval. Tests use fixedClock/advanceableClock instead of spying on Date.now, which never saw the V8-internal clock new Date() uses.
- FoldersService extracted from inline route logic, mirroring items/trash/shares shape; folder writes now run inside db.transaction(...).
- requireOwner/requireWriter/requireReader on vaults/access.ts consolidate the role-gate pattern duplicated across services.
- Drop duplicate PG 23505 try/catch in register and create-share; global error handler is the single mapping point.
- TxDb branded type (db/tx.ts) + asTx() — every write-path service signature and the quota advisory-lock helpers now require TxDb, making accidental calls on app.db a compile error. Closes a latent gap where pg_advisory_xact_lock would silently no-op without a surrounding transaction. - app.clock decorator (plugins/clock.ts) owns every time-sensitive read: session expiry, TOTP windows, recovery token expiry, auth idle check, cleanup interval. Tests use fixedClock/advanceableClock instead of spying on Date.now, which never saw the V8-internal clock new Date() uses. - FoldersService extracted from inline route logic, mirroring items/trash/shares shape; folder writes now run inside db.transaction(...). - requireOwner/requireWriter/requireReader on vaults/access.ts consolidate the role-gate pattern duplicated across services. - Drop duplicate PG 23505 try/catch in register and create-share; global error handler is the single mapping point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.