Conversation
Replace the raw token string returned by `session.issue` with a
branded `ProofOfSession` value consumed only by `session.attachCookie`.
The opaque type carries the cookie/row pairing obligation that was
previously a comment-only convention.
Defence-in-depth against leaking the token into response bodies:
`token` is non-enumerable and `toJSON` returns undefined, so spread,
Object.keys, and JSON.stringify all drop it — guarding against
`reply.send({ proof })` and Pino's serialiser. Add an integration
regression test asserting the session token never appears in the
completion-route bodies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the raw token string returned by
session.issuewith a brandedProofOfSessionvalue consumed only bysession.attachCookie. The opaque type carries the cookie/row pairing obligation that was previously a comment-only convention.Defence-in-depth against leaking the token into response bodies:
tokenis non-enumerable andtoJSONreturns undefined, so spread, Object.keys, and JSON.stringify all drop it — guarding againstreply.send({ proof })and Pino's serialiser. Add an integration regression test asserting the session token never appears in the completion-route bodies.