Repository navigation
[codex] fix native test expression passthrough - #1
Closed
allanbatista wants to merge 1 commit into
Closed
allanbatista wants to merge 1 commit into
allanbatista wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closed in favor of upstream PR: rtk-ai#2515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
testexpressions passed throughrtk test, such asrtk test -d graphify-out.testcommand via passthrough.rtk test cargo test.Problem
rtk test -d graphify-outfailed with:Running
test -d graphify-outdirectly worked.Root cause
testis also an RTK subcommand. Clap correctly routedrtk test -d graphify-outtoCommands::Test, but that handler joined the remaining args into a string and executed it throughsh -cfor RTK's test-output filtering.That produced
sh -c "-d graphify-out". POSIXshinterpreted-das an option to the shell command itself, not as an argument totest, which causedIllegal option -d.Proposed solution
When
Commands::Testreceives a nativetestexpression (-d,-f,!,(, etc.), bypass the RTK test-output wrapper and run the systemtestcommand directly with the original arguments. This keeps shell parsing out of the path and preserves the nativetestexit semantics.Validation
rtk cargo +1.91.0 fmt --all && rtk cargo +1.91.0 clippy --all-targets && rtk cargo +1.91.0 test --allrtk proxy ./target/debug/rtk test -d .rtk proxy ./target/debug/rtk test -d graphify-outrtk proxy ./target/debug/rtk test true