Repository navigation
Conversation
This was referenced Oct 10, 2026
Owner
Author
|
Consolidated into #30 at the same accepted final source tree (b66e06e), now targeting feature/connection-resource-access. Closing this individual stack PR as superseded; its commits, review record and branch remain preserved. No feature activation or main/upstream merge. Tracking issues remain open until integration verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection credentials cannot yet represent project and configured provider/model access. Ticket 01 adds that representation and persistence while restricted credentials stay unusable until activation.
Add version 1 resource grants with all/explicit project IDs and all/explicit configured provider instance entries, each with all/explicit canonical model IDs. Empty selections deny. Membership, intersection and subset helpers compare stable IDs without resolving catalogs. Migration 61 adds nullable resource_grant JSON, authority_revision and device_id columns to both auth tables. SQL NULL and absent legacy claims remain unrestricted; malformed explicit JSON, including JSON null, fails decoding.
ResourceGrantGuard.requireUnrestrictedResourceGrant gates pairing issuance/consumption, session issuance/replacement, and session/WebSocket verification and ticket conversion. Existing services forward pairing input to the gate. Cookie and OAuth exchange schemas reject submitted resourceGrant input instead of discarding it. Internal repository fixtures can persist restrictions for later tests; no edit API, device lifecycle, UI or active enforcement is introduced. Existing scopes/permissions responses stay compatible and advertise no resource enforcement.
Validation (all exit 0; executable node_modules/.bin/vp):
Base: feature/connection-resource-access. Only ticket 01; no merge or ticket 02 work. Restricted fixture links attempted before activation are consumed and rejected; restricted row decoding can reject a whole auth list. Both are fail-closed behavior. Model canonicalization, availability and resource enforcement belong to later tickets.
Closes #2.
Model: gpt-6.1-sol. Harness: Codex.