chore(version): bump algoliasearch version to v0.11.0#4938
Merged
Haroenv merged 6 commits intoalgolia:chore/bump-algoliasearchfrom Oct 21, 2021
bidoubiwa:refactor/bump-algoliasearch-v0-11-0
Merged
chore(version): bump algoliasearch version to v0.11.0#4938Haroenv merged 6 commits intoalgolia:chore/bump-algoliasearchfrom bidoubiwa:refactor/bump-algoliasearch-v0-11-0
Haroenv merged 6 commits intoalgolia:chore/bump-algoliasearchfrom
bidoubiwa:refactor/bump-algoliasearch-v0-11-0
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit febea68:
|
refactor(tests): Remove typescript ignore comments of boundinBox
* Import algoliasearch client with type fix * Remove unecessary type enforcement
Haroenv
changed the title
Contributor
|
This is very cool, thanks! I'd just need to make sure the CI runs on the v3 version of algoliasearch without errors now that the workarounds are removed |
Haroenv
approved these changes
Oct 21, 2021
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
looks good to merge to branch in our organisation (for CI)
Contributor
|
I made a "local" version of this PR and saw that CI is now failing for algoliasearch v3. I think we could either ts-ignore, keep the casting or keep everything as-is (except updating of course). What do you think @bidoubiwa? The algoliasearch (v3) types no longer exist on DefinitelyTyped, so I don't think we can add the string type there 🤔 |
Haroenv
added a commit
that referenced
this pull request
Nov 16, 2021
* chore(version): bump algoliasearch version to v0.11.0 (#4938) * refactor(version): bump algoliasearch version to v0.11.0 * Import algoliasearch tarball package with type fix * refactor(packages): Remove algoliasearch tarball * refactor(types): Remove type work-arround for boundingBox (#2) * Import algoliasearch client with type fix * Remove unecessary type enforcement * refactor(package): Bump algoliasearch to v0.11.0 fixes: #4916 * chore(version): Fix failing tests when using algoliasearch@v3 (#4941) * docs(contributing): Add doc on instantsearch cross version testing * fix(tests): Fixes insideboundingbox tests * core(geo): Reverse removal of geo forced typecasting * Update testing script in contributing * Typescript installation documentation * chore(version): reverse type enforcing functions (#4942) * update wordings, remove script * Apply suggestions from code review Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes: #4916
This PR updates
algoliasearchand@algolia/client-searchto the latest release:v0.11.0.This new version introduces a fix on the type of
insideBoundingBox(see algolia/algoliasearch-client-javascript#1310).insideBoundingBoxused to only accept aReadonlyArray<readonly number[]>;, wich was conflicting withinstantsearch.jsusing it as astring#4916 .The fix introduced in the new @algolia/client-search packages expanded the type of
insideBoundingBoxto also accept a string (this line).In this PR, the packages are updated and the code is made up-to-date with the introduced changes.
stringtype is removedResult