fix: address code review issues in --commit flag (PR #267)#2
Merged
alexander-turner merged 1 commit intofeat/issues-list-by-commitfrom Feb 9, 2026
Merged
Conversation
- Move regexp.MustCompile to package-level var (idiomatic Go) - Use cobra MarkFlagsMutuallyExclusive for --commit/--repo - Fix misleading "full commit SHA" doc comment - Add empty occurrences guard matching existing query patterns - Document --commit flag in README (resolves DeepSourceCorp#261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code quality issues in the
--commitflag implementation from PR DeepSourceCorp#267, and documents the feature in the README.regexp.MustCompileto package-level var — was recompiled insideRun()on every invocation; now compiled once at init (idiomatic Go)cobra.MarkFlagsMutuallyExclusivefor--commit/--repo— replaces manual if-check with cobra's built-in declarative APIlist_run_issues.go— matches the established pattern inlist_issues.goandlist_file_issues.go--commitflag in README with usage examplesTest plan
go build ./...passesgo vet ./...passesgo test ./command/issues/list/passesResolves DeepSourceCorp#261