Skip to content
This repository was archived by the owner on May 4, 2026. It is now read-only.
This repository was archived by the owner on May 4, 2026. It is now read-only.

$spacing not overwriteable #19

Open

Description

@robinsandborg

$spacing is defined as:
$spacing: $line-height;

If we try to overwrite $spacing in the settings, it will revert to whatever $line-height is. Should we add a !default to this one?

Activity

  1. macbruker commented on Jun 27, 2016

    @macbruker

    I think that would be nice.

    I am thinking it would be nice to disconnect $spacing and $line-height completely. It makes sense for those cases where you are working with unitless values for line-height.

  2. robinsandborg commented on Jun 27, 2016

    @robinsandborg
    MemberAuthor

    I think it’s a useful default though; having ´$spacing´ and ´$line-height´ set to the same number should contribute to a good vertical rythm.

    The ´font-size´ include converts the pixel value of $line-height to a unitless value, so no worries there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions