Implement replacement for the now-deprecated summarizeAssayByGroup.#225
Merged
Conversation
Owner
|
Looks good, I've not tested but I'll trust you as the author of both |
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A consequence of the grand deprecation of scuttle functions in favor of scrapper. I don't want scater to add a hard
Dependson scrapper so I've just implemented a quick-and-dirty summation function (inspired by a suggestion from @plger). This should be good enough given that we're only operating on a subset of features.Note that we might need to add a
Suggestson scrapper to replace the various deprecated scuttle functions in the Examples, e.g.,normalizeCounts()being replaced bynormalizeRnaCounts.se().