Skip to content

⚡ Optimize dictionary iteration in sbml2bngl #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akutuva21 merged 1 commit into from
Jun 16, 2026
Merged

⚡ Optimize dictionary iteration in sbml2bngl #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bionetgen/atomizer/sbml2bngl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ def find_all_symbols(self, math, reactionID):
for key, val in replace_dict.items():
form = re.sub(rf"\b{re.escape(key)}\b", val, form)
# Let's also pool this in used_symbols
for sym in self.all_syms.keys():
for sym in self.all_syms:
if sym not in self.used_symbols:
self.used_symbols.append(sym)
# Sympy doesn't allow and/not/or to be used
Expand Down
Loading