Skip to content

Use neutral styling for delete session menu items - #76

Merged
akemmanuel merged 1 commit into
masterfrom
neutralize-menu-delete-actions
Jun 11, 2026
Merged

akemmanuel merged 1 commit into
masterfrom
neutralize-menu-delete-actions

Conversation

@touch2be

@touch2be touch2be commented Jun 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove destructive/red styling from the session context menu delete item
  • Remove destructive variant from the session dropdown delete item
  • Leave project remove menu items with neutral styling

Verification

  • vp check in the active workspace: formatting passed; existing warning remains in claude-code-bridge.ts:1038 for probe.close() without void/await
  • vp check in the clean PR worktree could not run because dependencies were not installed there (@tailwindcss/vite, @vitejs/plugin-react, vite-plus)

@github-actions

Copy link
Copy Markdown

Confidence Score: 5/5

Changes:

  1. src/components/SessionContextMenu.tsx:291 — Removed text-destructive focus:text-destructive from the delete context menu item's className. The base CTX_ITEM_CLASS (defined in src/lib/constants.ts:84-85) has no destructive styling, so the delete item now renders neutrally, consistent with the rest of the menu.

  2. src/components/SidebarItemMenus.tsx:236 — Removed variant="destructive" from the delete DropdownMenuItem. Since variant is an optional prop, removing it is safe — the item falls back to the default neutral style.

Analysis:

  • No bugs. The variant prop is optional, and className merging works correctly without the removed classes.
  • No code quality issues. The change is focused, minimal (1-2 lines per file), and consistent between the context-menu and dropdown-menu variants.
  • Consistency check: Project-level remove items (both dropdown and context variants) were already neutral and remain untouched. Worktree remove items still retain variant="destructive" / text-destructive, which is intentional — the PR only targets session delete items.
  • The diff matches the description. Session delete items are now neutrally styled while destructive styling is preserved elsewhere (worktree remove actions).

New%20session%20-%202026-06-10T18%3A11%3A28.207Z
opencode session  |  github run

@akemmanuel
akemmanuel merged commit cbfe914 into master Jun 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants