Repository navigation
feat(identity): confirm email changes with owner-configured mail - #163
Open
akemmanuel wants to merge 1 commit into
Open
akemmanuel wants to merge 1 commit into
akemmanuel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #154 with the revised, approved scope: optional owner-configured SMTP and confirmed changes to a signed-in user's own contact email. No email/password recovery is added. Existing username login, profile editing, and owner-operated member password reset remain.
Review and verification
Independent final read-only security review found no blocking defects after corrections. Parent tests reproduced the credential-rotation-during-verification race, unbounded total SMTP delivery, and mailbox-list acceptance before fixing them.
Fresh independent parent verification: 385 passed across 53 identity/routes/Host/frontend/i18n files, plus
pnpm run check,pnpm run slop-check, andgit diff --checkpassed. Tests cover real routes, authentication, SQLite transactions, protected Host secret state, credential races, limits, and React effects; mail delivery uses injected/offline transports.Explicit limits