Repository navigation
fix(compaction): pause automatic retries until explicit recovery - #160
Open
akemmanuel wants to merge 1 commit into
Open
akemmanuel wants to merge 1 commit into
akemmanuel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #151. Stacked on #158 (
fix/compaction-handoff); this PR adds failure recovery, not a second handoff store.Implements the approved policy: after compaction fails, stop automatic attempts until an explicit
/compactretry succeeds. Keep the Session, its full history, accepted intent, and queued follow-ups; never silently discard context or force a new chat.Verification
Tests cover one automatic attempt across repeated prompts and restart; authorized retry and revoked grants; preserved history/files/queued intent with single dispatch; cancellation; storage-failure fallback; live failed-entry delivery; failed-provider telemetry; projection and error-render transitions.
Parent review requested and checked corrections for missing live events, lost provider metadata, stale in-progress rows, and invalid hook ordering. Fresh independent parent verification after corrections:
pnpm run check,pnpm run slop-check,git diff --check: passed.No schema/store changes, filesystem exceptions, new Host routes, production commands, real provider calls, deployment, or merges. Live deployed acceptance remains separate from these local regression tests.