Repository navigation
fix(sandbox): check configured shell image during preflight - #157
Open
akemmanuel wants to merge 1 commit into
Open
akemmanuel wants to merge 1 commit into
akemmanuel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #152. This is a small, independently reviewable preflight fix, not completion of the image-lifecycle incident.
OPENGUI_SHELL_IMAGEin the selected Docker daemon when it is configured; fail preflight on a missing image, Docker failure, or invalid inspection result.Reproduction and tests
Before the fix, a healthy daemon/files fixture with
shellImageAvailable: falseincorrectly returned no findings. The added regression failed withexpected [] to include 'OPENGUI_SHELL_IMAGE is not available …'and passes after the fix.vp test scripts/sandbox-doctor.test.ts scripts/sandbox-shell-broker.test.ts scripts/sandbox-host.test.ts --maxWorkers=2— pass.vp check— pass.git diff --check— pass.Docker is injected in tests: present/missing images, daemon failure, malformed inspection output, no pulling, broker-free compatibility, and diagnostic privacy are exercised without modifying a Docker daemon.
Explicit remaining work
#152 remains open. This does not install retention/keepers, locked cleanup, recurring real execution probes, external alerting, image distribution/restoration, or upgrade/rollback orchestration. A production revision/configuration audit and scoped disposable Docker lifecycle tests still need separate approval/evidence. No production deployment or pruning was performed.