Repository navigation
test(instructions): verify personal persistence and actor isolation - #156
Open
akemmanuel wants to merge 1 commit into
Open
akemmanuel wants to merge 1 commit into
akemmanuel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #155. Test-only verification, not a claim that the reported deployed incident has been fixed or reproduced.
Current master already implements persistent Host/Project/Personal instructions. The local two-Account tests passed without implementation changes, so this PR adds missing regression coverage rather than a second instruction store or speculative fix.
ModelRequest.systemPromptfor alternating actors on the same Session and an API-key turn; Personal text follows the requesting actor, not the Session creator, and is not inherited by API keys.The same-Session context test uses the Host/Harness actor seam directly; it is not a browser/deployed restricted-Account authorization test. Existing tests cover instruction composition, queued actors, Project permissions, and scope copy.
Verification
Independently rerun by the parent:
vp test packages/backend/src/host/opengui-host.instructions.test.ts packages/backend/src/identity/project-instructions.integration.test.ts packages/backend/src/identity/personal-instructions.verification.test.ts src/features/instructions/InstructionsSettings.render.test.tsx --maxWorkers=2— 14 passed.vp check— pass.pnpm run slop-check— pass.git diff --check— pass.All markers and Accounts are harmless local fixtures; no customer instructions or production data were used.
Remaining acceptance
#155 remains open pending actual deployed revision/configuration parity and reproduction. Long-Session manual/threshold compaction is coordinated with #150/#151 and is not claimed by these tests. Local browser acceptance scripts currently fail on stale UI selectors (
New session/Host account); those runs are not evidence that this acceptance is satisfied. No scope, permission, UI text, or persistence contract changed.