Repository navigation
chore(cloudflare): drop fork OAuth Basic D1 schema patch - #21
Closed
omega-alpha-matt[bot] wants to merge 1 commit into
Closed
omega-alpha-matt[bot] wants to merge 1 commit into
omega-alpha-matt[bot] wants to merge 1 commit into
Conversation
Upstream v1.6.8 already stores token_endpoint_auth_method and authenticates confidential clients with HTTP Basic. The Cloudflare ALTER was the last remaining fork copy of that work. Co-authored-by: Matt Hodgson <matthodgson@mac.com>
Author
|
Closing: this only dropped the Cloudflare D1 ALTER. The v1.6.8 sync skipped the UsefulSoftwareCo#1448 token-auth commits (interoperable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed: upstream v1.6.8 already supports HTTP Basic client authentication for registered OAuth apps (
client_secret_basic, plusbasic_rawfor providers that reject form-encoded credentials). The SDK, API, React form, and cloud/local drizzle migrations on this fork already match that release — those product commits were not replayed in the v1.6.8 sync.The only remaining fork copy was a Cloudflare D1 compatibility ALTER that added
oauth_client.token_endpoint_auth_method. This drops it so the Workers host matches upstream.Production D1 already has the column from earlier deploys of the fork patch; new tables get it from FumaDB
core-schema. The Access service-token subject mapping is unrelated and stays.Verified
apps/host-cloudflaredata-migrationstests (4)git diff v1.6.8 -- apps/host-cloudflare/src/db/data-migrations.tsis empty