Skip to content

feat: include pst_tap in enriched action topology - #48

Merged
marota merged 3 commits into
mainfrom
feat/pst-integration
Mar 11, 2026
Merged

marota merged 3 commits into
mainfrom
feat/pst-integration

Conversation

@marota

@marota marota commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

Include pst_tap in Enriched Action Topology

This Pull Request updates the RecommenderService to extract and include Phase Shifter Transformer (PST) tap information in the action_topology field of enriched actions.

Changes Overview

Backend Integration (recommender_service.py)

  • Updated RecommenderService._enrich_actions to extract the pst_tap attribute from the underlying action objects.
  • This ensures that when PST tap variations are proposed by the recommender, the specific tap changes (e.g., {"PST1": 12}) are sent to the frontend.

Verification Results

Automated Tests

  • Verified the enrichment logic with a new unit test in Expert_op4grid_recommender's test suite that specifically mocks the RecommenderService and checks for the presence of pst_tap in the output.
  • Combined with the core changes in Expert_op4grid_recommender, this completes the end-to-end integration of PST actions.

Linked PR: marota/Expert_op4grid_recommender#58

marota added 3 commits March 10, 2026 21:19
This commit updates RecommenderService to extract and include PST tap information in the action_topology field of enriched actions, ensuring visibility in the UI.
…or disconnection simply of the related network branch
…t primary action categories like Disconnections take precedence. I've also resolved all frontend lint errors and mirrored these improvements to the standalone interface for consistency. Verification was completed with 13 tests passing and logic hardening in both interfaces.
@marota
marota merged commit 0572869 into main Mar 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant