Conversation
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
requested review from
Ronkahn21,
danbar2,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
September 24, 2026 05:48
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the four unresolved moderate review findings before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Documents GPU NUMA locality using Kubernetes DRA without runtime changes.
Changes:
- Adds a DRA-based GPU locality sample.
- Adds user-guide guidance and prerequisites.
- Links GREP-244 to the new approach.
Unresolved moderate issues include the missing namespace, an image without nvidia-smi, and incomplete NVIDIA DRA NUMA attribute prerequisites.
| File | Description |
|---|---|
operator/samples/user-guide/04_topology-aware-scheduling/single-pod.yaml |
Adds the DRA GPU locality example. |
docs/user-guide/topology-aware-scheduling.md |
Documents GPU NUMA locality usage. |
docs/proposals/244-topology-aware-scheduling/README.md |
Links the proposal story to the DRA pattern. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| kind: ResourceClaimTemplate | ||
| metadata: | ||
| name: decode-four-gpus | ||
| namespace: numa-locality |
| resourceClaimTemplateName: decode-four-gpus | ||
| containers: | ||
| - name: decode | ||
| image: ubuntu:24.04 |
|
Looks mostly good besides copilot comments above. Two things that might be worth mentioning in the user guide section:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documents GPU NUMA locality with DRA: a minimal PodCliqueSet example, a short user-guide section, and a link from GREP-244. No API or runtime changes.
Which issue(s) this PR fixes:
Related to #644 (Case 1 only).
Special notes for your reviewer:
Checks passed: server-side dry-run,
make verify-toc, andgit diff --check. Earlier mock DRA runtime tests passed 7/7 scenarios; physical NVIDIA multi-GPU validation remains outstanding.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.:
GREP-244: Topology-Aware Scheduling