Skip to content

Fix ClusterTopologyBinding shortName collision with pre-rename CRD - #805

Closed
SAY-5 wants to merge 2 commits into
ai-dynamo:mainfrom
SAY-5:fix/clustertopologybinding-shortname-collision
Closed

SAY-5 wants to merge 2 commits into
ai-dynamo:mainfrom
SAY-5:fix/clustertopologybinding-shortname-collision

Conversation

@SAY-5

@SAY-5 SAY-5 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug
/kind api

What this PR does / why we need it:

ClusterTopologyBinding still claims the shortName ct, which was ClusterTopology's shortName before the rename in #616. Helm does not remove the old CRD on upgrade, so a cluster that ran the pre-rename version ends up with both CRDs claiming ct, the new CRD never reaches Established, and the operator crash loops on startup. Giving the renamed type its own shortName ctb removes the collision.

Which issue(s) this PR fixes:

Fixes #801

Special notes for your reviewer:

Ran make --directory=operator/api generate to regenerate the CRD yaml instead of hand editing it.

Does this PR introduce a API change?

ClusterTopologyBinding's kubectl short name changed from ct to ctb to avoid colliding with the pre-rename ClusterTopology CRD on upgraded clusters.

Additional documentation e.g., enhancement proposals, usage docs, etc.:


Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@SAY-5

SAY-5 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Closing, #812 landed the same ct to ctb change and shipped in alpha.13.

@SAY-5 SAY-5 closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClusterTopologyBinding shortName 'ct' collides with the pre-rename ClusterTopology CRD, leaving the operator in CrashLoopBackOff after upgrade

1 participant