Pin the path the native forwarder sends upstream - #75
Merged
Conversation
A path on the binding is appended to the caller's own, so an upstream carrying one forwards it twice. The vendor answers 404 and it reads as a missing endpoint rather than a composition bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for the composition in
buildRequest:The caller's whole path is appended, so an upstream that carries a path of its own sends it twice. That is what made codex's
/backend-api/codex/responsesarrive as/backend-api/codex/backend-api/codex/responsesand come back 404 — which reads as a missing endpoint rather than a bug here. Fixed on the binding side in llm#56; this stops it recurring silently.